RFR: 8259486: Replace PreserveExceptionMark with implementation for CautiouslyPreserveExceptionMark [v3]

[David Holmes]

On Mon, 11 Jan 2021 16:33:12 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> See CR for details.  This is a hopefully simple cleanup.  I didn't try to reason about removing any of these except an obvious call (if you look above the patch in thread.cpp).
>> Tested with tier1-3.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix wrong JavaThread::active in fill_in_stack_trace.

Hi Coleen,

This all seems fine to me. One minor nit below.

Thanks,
David

src/hotspot/share/utilities/preserveException.cpp line 32:

> 30: 
> 31: PreserveExceptionMark::PreserveExceptionMark(Thread* thread) {
> 32:   _thread    = thread;

Nit: extra spaces before = now that lines are not being aligned.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2007