RFR: 8256955: Move includes of events.hpp out of header files

Coleen Phillimore coleenp at openjdk.java.net
Wed Jan 13 14:22:05 UTC 2021


On Wed, 13 Jan 2021 14:18:57 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> I was making changes to events.hpp and saw that the majority of cpp files were recompiled. There are two header files that include events.hpp. I propose that we remove those usages by:
>> 
>> jvmci.hpp: Use a forward declaration
>> collectedHeap.hpp: Move its usage to the cpp file
>> 
>> events.hpp also includes thread.hpp, which brings in a large portion of the HotSpot headers. So, this change is also good in that regard.
>
> Nice!

I should have asked if you were able to build shenandoah and zero with this change?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2059


More information about the hotspot-dev mailing list