RFR: 8259713: Fix comments and ResetNoHandleMark in deoptimization

Daniel D.Daugherty dcubed at openjdk.java.net
Wed Jan 13 22:45:01 UTC 2021


On Wed, 13 Jan 2021 21:44:07 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> This is a small part of the withdrawn change for https://github.com/openjdk/jdk/pull/1990 to fix the out-of-date comments in deoptimization.cpp.
>> Tested with tier1-3.
>
> Changes requested by dcubed (Reviewer).

The comment in the bug says this:

> The comments are wrong and the ResetNoHandleMark is unneeded
> since Deoptimization::fetch_unroll_info is a JRT_BLOCK_ENTRY (has a HandleMarkCleaner). 

so I read this as you are changing Deoptimization::fetch_unroll_info to:

- fix a comment
- remove a ResetNoHandleMark

The comment in the bug doesn't mention JRT_LEAF at all, but you're
making comment changes there also.

No where in this fix do I see a ResetNoHandleMark being removed.

Is the reason for my confusion more clear yet?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2069


More information about the hotspot-dev mailing list