RFR: 8259713: Fix comments about ResetNoHandleMark in deoptimization [v2]

Daniel D.Daugherty dcubed at openjdk.java.net
Thu Jan 14 14:50:05 UTC 2021


On Thu, 14 Jan 2021 13:51:14 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This is a small part of the withdrawn change for https://github.com/openjdk/jdk/pull/1990 to fix the out-of-date comments in deoptimization.cpp.
>> Tested with tier1-3.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use David's comment.

I like David's comment much more than the one I proposed!
Thumbs up! For the first time in a long time, I had to use a
webrev to review the code since there were so many comments
in the Git view that made it hard to see the code... :-)

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2069


More information about the hotspot-dev mailing list