RFR: 8258004: Remove unnecessary inclusion of vm_version.hpp

Ioi Lam iklam at openjdk.java.net
Fri Jan 15 23:08:29 UTC 2021


In the x86 build, vm_version.hpp includes vm_version_x86.hpp, which is over 1000 lines due to the complexity of the Intel architecture.

vm_version.hpp is unnecessarily included by these popular header files:
- assembler.hpp
- assembler_x86.hpp
- threadLocalAllocBuffer.hpp

Before this change, there are 822 .o files that include vm_version.hpp. Refactoring the code reduces the number to 220 .o files.

Review note: the main change is in the 3 files mentioned above. All the other files had to be fixed because they were using declarations from vm_version.hpp without including it explicitly.

-------------

Commit messages:
 - 8258004: Remove unnecessary inclusion of vm_version.hpp

Changes: https://git.openjdk.java.net/jdk/pull/2105/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2105&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8258004
  Stats: 157 lines in 30 files changed: 81 ins; 49 del; 27 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2105.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2105/head:pull/2105

PR: https://git.openjdk.java.net/jdk/pull/2105


More information about the hotspot-dev mailing list