RFR: 8258004: Remove unnecessary inclusion of vm_version.hpp

Stefan Karlsson stefank at openjdk.java.net
Mon Jan 18 08:16:38 UTC 2021


On Fri, 15 Jan 2021 22:13:50 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> In the x86 build, vm_version.hpp includes vm_version_x86.hpp, which is over 1000 lines due to the complexity of the Intel architecture.
> 
> vm_version.hpp is unnecessarily included by these popular header files:
> - assembler.hpp
> - assembler_x86.hpp
> - threadLocalAllocBuffer.hpp
> 
> Before this change, there are 822 .o files that include vm_version.hpp. Refactoring the code reduces the number to 220 .o files.
> 
> Review note: the main change is in the 3 files mentioned above. All the other files had to be fixed because they were using declarations from vm_version.hpp without including it explicitly.

Marked as reviewed by stefank (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2105


More information about the hotspot-dev mailing list