RFR: 8258004: Remove unnecessary inclusion of vm_version.hpp [v2]

Ioi Lam iklam at openjdk.java.net
Tue Jan 19 04:36:09 UTC 2021


> In the x86 build, vm_version.hpp includes vm_version_x86.hpp, which is over 1000 lines due to the complexity of the Intel architecture.
> 
> vm_version.hpp is unnecessarily included by these popular header files:
> - assembler.hpp
> - assembler_x86.hpp
> - threadLocalAllocBuffer.hpp
> 
> Before this change, there are 822 .o files that include vm_version.hpp. Refactoring the code reduces the number to 220 .o files.
> 
> Review note: the main change is in the 3 files mentioned above. All the other files had to be fixed because they were using declarations from vm_version.hpp without including it explicitly.

Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into 8258004-unnecessary-inclusion-vm_version.hpp
 - 8258004: Remove unnecessary inclusion of vm_version.hpp

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2105/files
  - new: https://git.openjdk.java.net/jdk/pull/2105/files/97710ade..c4924e55

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2105&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2105&range=00-01

  Stats: 11983 lines in 108 files changed: 1328 ins; 9224 del; 1431 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2105.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2105/head:pull/2105

PR: https://git.openjdk.java.net/jdk/pull/2105


More information about the hotspot-dev mailing list