RFR: 8259894: refactor parts of jvm.h into jvm_io.h and jvm_constants.h

Ioi Lam iklam at openjdk.java.net
Wed Jan 20 04:47:04 UTC 2021


jvm.h is over 1000 lines long. It is included by 940 out of 1000 HotSpot .o files. However, most of the HotSpot source files just use a small fraction of jvm.h:

- the jio_xxxprintf() functions
- the JVM_RECOGNIZED_XXX_MODIFIERS defines

We should move these two parts into jvm_io.h and jvm_constants.h. This reduces the files that include jvm.h to about 82 files. Build time of HotSpot is reduced by about 0.4%.

Testing: mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5. Also locally: aarch64, arm, ppc64, s390, x86, and zero.

-------------

Commit messages:
 - 8259894: refactor parts of jvm.h into jvm_io.h and jvm_constants.h

Changes: https://git.openjdk.java.net/jdk/pull/2154/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2154&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8259894
  Stats: 248 lines in 16 files changed: 145 ins; 86 del; 17 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2154.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2154/head:pull/2154

PR: https://git.openjdk.java.net/jdk/pull/2154


More information about the hotspot-dev mailing list