RFR: 8259894: refactor parts of jvm.h into jvm_io.h and jvm_constants.h [v2]
Ioi Lam
iklam at openjdk.java.net
Thu Jan 21 03:09:13 UTC 2021
> jvm.h is over 1000 lines long. It is included by 940 out of 1000 HotSpot .o files. However, most of the HotSpot source files just use a small fraction of jvm.h:
>
> - the jio_xxxprintf() functions
> - the JVM_RECOGNIZED_XXX_MODIFIERS defines
>
> We should move these two parts into jvm_io.h and jvm_constants.h. This reduces the files that include jvm.h to about 82 files. Build time of HotSpot is reduced by about 0.4%.
>
> Testing: mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5. Also locally: aarch64, arm, ppc64, s390, x86, and zero.
Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
David Holmes comments
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2154/files
- new: https://git.openjdk.java.net/jdk/pull/2154/files/f3cce1ba..00fc5db5
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2154&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2154&range=00-01
Stats: 16 lines in 5 files changed: 2 ins; 3 del; 11 mod
Patch: https://git.openjdk.java.net/jdk/pull/2154.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/2154/head:pull/2154
PR: https://git.openjdk.java.net/jdk/pull/2154
More information about the hotspot-dev
mailing list