RFR: 8260191: Do not include access.hpp in oop.hpp

Ioi Lam iklam at openjdk.java.net
Thu Jan 21 03:56:49 UTC 2021


On Thu, 21 Jan 2021 02:09:23 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Please review this trivial change.
>> 
>> oop.h is included by 860 out of 1000 HotSpot .o files. It includes access.h for this member function declaration only:
>> 
>> template <DecoratorSet decorator> oop obj_field_access(int offset) const;
>> 
>> Instead of access.h, oop.h should include accessDecorators.hpp. This avoids including lots of header files from the Access API.
>> 
>> HotSpot build time is reduced by about 0.5% for this single-line change.
>> 
>> Tested with mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5. Also locally: aarch64, arm, ppc64, s390, x86, and zero.
>
> Forgot to say earlier, I agree this is trivial.

Thanks @kimbarrett for the review!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2172


More information about the hotspot-dev mailing list