RFR: JDK-8260022: [ppc] os::print_function_and_library_name shall resolve function descriptors transparently [v2]
Thomas Stuefe
stuefe at openjdk.java.net
Thu Jan 21 10:08:16 UTC 2021
On Thu, 21 Jan 2021 09:52:30 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix build errors on ppcle and AIX
>
> src/hotspot/os_cpu/linux_ppc/os_linux_ppc.hpp line 35:
>
>> 33: static bool register_code_area(char *low, char *high) { return true; }
>> 34:
>> 35: #ifndef VM_LITTLE_ENDIAN
>
> I'd prefer using #ifndef ABI_ELFv2 because it's directly related to the ABI, not to the endianess. It is used to control function descriptor related code usage in elfFile.cpp. (It'd be great if we could use HAVE_FUNCTION_DESCRIPTORS there, too, but this may not fit well to your change.)
Makes sense. I changed it to use ABI_ELFv2.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2157
More information about the hotspot-dev
mailing list