RFR: 8260009: InstanceKlass::has_as_permitted_subclass() fails if subclass was redefined
Serguei Spitsyn
sspitsyn at openjdk.java.net
Thu Jan 21 21:02:01 UTC 2021
On Thu, 21 Jan 2021 13:41:44 GMT, Harold Seigel <hseigel at openjdk.org> wrote:
> Please review this fix for JDK-8260009. The fix removes the "if (k2 == k)" check for a valid permitted subclass because the check does not work if "k" is being redefined. It fails because 'k' is a temporary InstanceKlass created when loading the redefined class.
>
> Instead, the code relies on a name check to determine if 'k' is a permitted subclass.
>
> The fix was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, tiers 3-5 on Linux x64, and JCK Lang and VM tests.
>
> Thanks, Harold
Hi Harold,
The fix looks good to me.
Thanks,
Serguei
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2184
More information about the hotspot-dev
mailing list