RFR: JDK-8260030: Improve stringStream buffer handling [v2]
Thomas Stuefe
stuefe at openjdk.java.net
Fri Jan 22 09:04:17 UTC 2021
On Thu, 21 Jan 2021 23:30:05 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Kim Feedback
>
> Other than the minor nit about use of `_is_fixed` in the destructor, looks good.
Thanks Kim, Ioi.
> src/hotspot/share/utilities/ostream.cpp line 414:
>
>> 412:
>> 413: stringStream::~stringStream() {
>> 414: if (_is_fixed == false && _buffer != _small_buffer) {
>
> Still using `_is_fixed == false` rather than `!_is_fixed`.
Oh, I missed that, sorry. Will fix before integration.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2160
More information about the hotspot-dev
mailing list