RFR: 8260009: InstanceKlass::has_as_permitted_subclass() fails if subclass was redefined [v2]

Harold Seigel hseigel at openjdk.java.net
Fri Jan 22 13:46:17 UTC 2021


> Please review this fix for JDK-8260009.  The fix removes the "if (k2 == k)" check for a valid permitted subclass because the check does not work if "k" is being redefined.  It fails because 'k' is a temporary InstanceKlass created when loading the redefined class.
> 
> Instead, the code relies on a name check to determine if 'k' is a permitted subclass.
> 
> The fix was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, tiers 3-5 on Linux x64, and JCK Lang and VM tests.
> 
> Thanks, Harold

Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:

  8260009: remove comment

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2184/files
  - new: https://git.openjdk.java.net/jdk/pull/2184/files/ca70228f..2303ef1d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2184&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2184&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2184.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2184/head:pull/2184

PR: https://git.openjdk.java.net/jdk/pull/2184


More information about the hotspot-dev mailing list