[jdk16] RFR: 8260339: JVM crashes when executing PhaseIdealLoop::match_fill_loop [v3]

[Nils Eliasson]

On Tue, 26 Jan 2021 08:03:56 GMT, Wang Huang <whuang at openjdk.org> wrote:

>> The reason is :
>> 
>>   BasicType t = store->as_Mem()->memory_type();
>>   const char* fill_name;
>>   if (msg == NULL &&
>>       StubRoutines::select_fill_function(t, false, fill_name) == NULL) {
>>     msg = "unsupported store";
>>     msg_node = store;
>>   }
>> 
>> If the `store` is a `StoreVectorNode` ,the `BasicType` is `T_VOID`. It seems that we don't need to intrinsify a `StoreVectorNode` filling here.
>> 
>> I add a new case here to avoid mistake:
>>   case T_NARROWOOP:
>>   case T_NARROWKLASS:
>>   case T_ADDRESS:
>> +  case T_VOID:
>>     // Currently unsupported
>>     return NULL;
>
> Wang Huang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.

The fix looks good.

Since JDK 16 is in rampdown phase 2 (http://openjdk.java.net/jeps/3) - this fix will need additional approval before it can be pushed. I will help out with that.

-------------

PR: https://git.openjdk.java.net/jdk16/pull/132