RFR: JDK-8260404: jvm_io.h include missing in a number of files
Aleksey Shipilev
shade at openjdk.java.net
Tue Jan 26 17:02:54 UTC 2021
On Tue, 26 Jan 2021 10:22:09 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> One of the last include corrections caused a build error on our AIX machines because compile.cpp uses jio_snprintf() without including jvm_io.h.
>
> I did not deeply follow up on the why, but "8260307: Do not include method.hpp in frame.hpp" is a possible candidate. AIX builds without JFR and hence miss a number of include chains other platforms have.
>
> I scanned hotspot sources for files using jio_snprintf but not including jvm_io.h. There are some hits, which should be fixed.
>
> All this is trivial, right?
Ah. I saw x86_32 build failures as well, so I PR'ed #2237. I think you linked this issue incorrectly to JDK-8260404, not JDK-8259894, and that is why I missed it. If you are about to propose this PR, I can close mine as duplicate.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2232
More information about the hotspot-dev
mailing list