[jdk17] RFR: 8269697: JNI_GetPrimitiveArrayCritical() should not accept object array [v2]

[Aleksey Shipilev]

On Thu, 1 Jul 2021 00:34:26 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

>> GetPrimitiveArrayCritical() is supposed to only be used with primitive array types, but nothing prevents current implementation from accepting object arrays (please see attached test case in bug).
>> 
>> My purposed fix is not very friendly, it crashes JVM if a none primitive array is passed in, but I am sure what to expect in this scenario.
>> 
>> Specification people, please comment. Thanks!
>
> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Kim's comment

Yes, returning `NULL` would be much saner here. That would alleviate my concern: the out-of-spec users would have a clear failure result. (It should be done before trying to lock/pin the object, of course).

-------------

PR: https://git.openjdk.java.net/jdk17/pull/185