RFR: 8268364: jmethod clearing should be done during unloading

Daniel D.Daugherty dcubed at openjdk.java.net
Thu Jul 1 14:36:05 UTC 2021


On Thu, 1 Jul 2021 12:17:58 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/oops/method.cpp line 2257:
>> 
>>> 2255:   if (mid == NULL) return NULL;
>>> 2256:   Method* o = resolve_jmethod_id(mid);
>>> 2257:   if (o == NULL || o == JNIMethodBlock::_free_method) {
>> 
>> I need to think more about deleting the is_method() check.
>
> The is_method() check was from when JNIHandleBlocks contained both jmethodID's and jobjects.  It's a leftover from permgen elimination. I should have mentioned that in the PR comments.  Now the only things that can be put in the JNIMethodBlocks are Methods, which the compiler type-checks, so that's the only thing that can come out (unless corrupted).

Thanks for the explanation.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4643


More information about the hotspot-dev mailing list