RFR: 8269697: JNI_GetPrimitiveArrayCritical() should not accept object array

[David Holmes]

On Thu, 1 Jul 2021 13:41:15 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

> Open this PR to carry on the discussion started in jdk17 [https://github.com/openjdk/jdk17/pull/185](url)

Hi Zhengyu,

Please put the test under runtime/jni/checked.

The actual code change is fine by me. I will discuss the compatibility issue elsewhere.

Thanks,
David

test/hotspot/jtreg/runtime/jni/TestPrimitiveArrayCriticalWithBadParam/TestPrimitiveArrayCriticalWithBadParam.java line 29:

> 27:  * @summary -Xcheck:jni should catch wrong parameter passed to GetPrimitiveArrayCritical
> 28:  * @library /test/lib
> 29:  * @run main/othervm/native TestPrimitiveArrayCriticalWithBadParam

othervm is not needed, but you will need to explicitly set the library path for the launched VM.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4653