RFR: 8267303: Replace MinObjectAlignmentSize usages for non-Java heap objects

Kim Barrett kbarrett at openjdk.java.net
Sun Jul 4 22:41:51 UTC 2021


On Fri, 2 Jul 2021 20:36:23 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> Replace '3' and LogMinObjAlignmentInBytes with LogBytesPerWord (3 for LP64 and 2 for 32 bits).
> Hoping git actions will test 32 bits.
> Tested with tier1 on all Oracle platforms, but since I didn't change the values for our platforms, no failures expected.

Change looks good.  Just a question in the comments.

src/hotspot/share/oops/symbol.hpp line 158:

> 156:   static int max_length() { return max_symbol_length; }
> 157:   unsigned identity_hash() const {
> 158:     unsigned addr_bits = (unsigned)((uintptr_t)this >> (LogBytesPerWord + 3));

[pre-existing] I'm puzzled by the `+3` in this line.  I'm guessing this is `log2(sizeof(Symbol))`?

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4675


More information about the hotspot-dev mailing list