RFR: 8253779: Amalloc may be wasting space by overaligning [v2]

Kim Barrett kbarrett at openjdk.java.net
Fri Jul 9 04:07:51 UTC 2021


On Fri, 9 Jul 2021 01:25:15 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Thanks to @kimbarrett for noticing this. The alignment was changed to 64 bits for 32 bit platforms, but overalign for 64 bits platforms.  I changed this to BytesPerLong to cover both, since the long case is why it was changed on 32 bits in the first place in JDK-4526490.
>> I also removed Amalloc_D since I don't know what D stands for and it's the same as Amalloc_4.  That's not a great name either. I'm open to suggestions!
>> Tested with tier1-3.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Improvements ala Kim

I replied to some "outdated" conversation threads.  I'm not sure how that will show up in the UI or in the Skara emails.  GitHub seems to be aggressively hiding some of the conversations in the "Files changed" view, which seems pretty unhelpful.

-------------

Changes requested by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4732


More information about the hotspot-dev mailing list