RFR: 8270179: Rename Amalloc_4
Coleen Phillimore
coleenp at openjdk.java.net
Mon Jul 12 13:54:53 UTC 2021
On Mon, 12 Jul 2021 05:20:44 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> This renames Amalloc_4 to AmallocWords. While I had to fix internal_malloc_4, which is a copy of Amalloc_4 (except with UseMallocOnly handling), I also made the change for
>> JDK-8270217 Fix Arena::Amalloc to check for overflow better
>> Tested with tier1 - all Oracle platforms and tier1-3 on linux-x64.
>
> src/hotspot/share/memory/arena.hpp line 105:
>
>> 103: debug_only(void* malloc(size_t size);)
>> 104:
>> 105: void* internal_malloc_words(size_t x, AllocFailType alloc_failmode = AllocFailStrategy::EXIT_OOM) {
>
> If UseMallocOnly is retained, I think a better name for this would be internal_amalloc_only, to avoid confusion with the case of actually using malloc. (And yes, this can be taken as another argument for nuking that option.)
Ok. I'll file another RFE for removing UseMallocOnly.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4750
More information about the hotspot-dev
mailing list