RFR: 8215948: [TESTBUG] gtest pseudo-JavaThreads could be more regular JavaThreads

David Holmes david.holmes at oracle.com
Tue Jul 13 01:44:47 UTC 2021


On 13/07/2021 9:52 am, Coleen Phillimore wrote:
> On Wed, 7 Jul 2021 07:03:55 GMT, David Holmes <dholmes at openjdk.org> wrote:
> 
>> Please review this change to the gtest infrastructure that makes the test JavaThreads more regular JavaThreads, with the same lifecycle methods and having a regular j.l.Thread object.
>>
>> One test had to be modified slightly to create and start the threads outside of a code region where a Mutex is held.
>>
>> Testing: tiers 1-3, GHA
>>
>> Thanks,
>> David
> 
> This looks good.

Thanks for the review Coleen!

Can I get a second review please.

David

> -------------
> 
> Marked as reviewed by coleenp (Reviewer).
> 
> PR: https://git.openjdk.java.net/jdk/pull/4704
> 


More information about the hotspot-dev mailing list