RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v5]

[Severin Gehwolf]

On Thu, 22 Jul 2021 12:15:03 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin/master' into JDK-8266490
>>  - Add hotspot tests
>>  - test and small adjustments suggested by Severin
>>  - Adjustments following Severins comments
>>  - JDK-8266490
>
> Hi Severin, thanks for the comments. I added a commit with a number of adjustments 
> 
> src/hotspot/os/linux/cgroupSubsystem_linux.cpp
> adjusted log_info to log_debug
> 
> src/java.base/share/classes/sun/launcher/LauncherHelper.java
> adjusted the output to "Maximum Processes Limit:"
> 
> test/hotspot/jtreg/containers/docker/CheckOperatingSystemMXBean.java
> removed the getPidsMax related line (I think I inserted it while running some tests and forgot previously to remove it)
> 
> test/hotspot/jtreg/containers/docker/TestPids.java
> added testing of "Unlimited"; added  --pids-limit=-1  for  Unlimited procs like you suggested
> 
> test/jdk/jdk/internal/platform/docker/TestPidsLimit.java
> adjusted output; added  --pids-limit=-1  for  Unlimited procs like you suggested

@MBaesken Thanks. We need a solution for https://github.com/openjdk/jdk/pull/4518#issuecomment-882637594 though. `--pids-limit=-1` doesn't seem to make it unlimited on all container runtimes. For example it fails for me here with:


$ docker --version
Docker version 20.10.6, build 370c289

-------------

PR: https://git.openjdk.java.net/jdk/pull/4518