RFR: JDK-8270308: Amalloc aligns size but not return value (take 2) [v2]

Thomas Stuefe stuefe at openjdk.java.net
Sat Jul 24 04:58:04 UTC 2021


On Wed, 21 Jul 2021 13:31:10 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix +UseMallocOnly on 32-bit
>
> I don't know if I can speak for everybody but I think cleanups in this area would be welcome if they're incremental and we can plan for time to review them. This hasn't been an area of pain for us (that I know of), but if it has for SAP, maybe cleanups like allowing packing in arenas has a higher priority.
> Having a GrowableArray for UseMallocOnly might make sense. I was somewhat surprised by this implementation last week when I first looked at it closely.  Or maybe UseMallocOnly could be removed in favor of memory guards in arena in debug mode, since UseMallocOnly is sparingly tested.  That would be my preference anyway.
> Thanks for taking this on and your thoughts on this.

@coleenp, @kimbarrett is this current version okay for you?

-------------

PR: https://git.openjdk.java.net/jdk/pull/4835


More information about the hotspot-dev mailing list