RFR: JDK-8270308: Amalloc aligns size but not return value (take 2) [v3]
Thomas Stuefe
stuefe at openjdk.java.net
Sat Jul 24 11:29:02 UTC 2021
On Sat, 24 Jul 2021 08:50:55 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
> The comment here is stale.
Yes, I know. See my initial PR text.
I left it in since my first fix was rejected for being too complex, so I wanted to limit this patch to the absolute minimum needed.
I do not think aligning the allocation size - or insisting on an aligned allocation size as the sister method `AmallocWords` does - is useful at all. Removing the comment just leaves the code, which leaves the reader to ask himself why it's in there. Leaving the comment at least states the reason the original author saw. We should either remove the code and the comment or leave both in place.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4835
More information about the hotspot-dev
mailing list