RFR: JDK-8270308: Amalloc aligns size but not return value (take 2) [v4]
Thomas Stuefe
stuefe at openjdk.java.net
Mon Jul 26 17:27:30 UTC 2021
On Mon, 26 Jul 2021 13:39:29 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> > My first patch filled alignment gaps in debug with a pattern, to trip off the analyzer. What do you think, should I do this here too?
> Maybe. Aren't arena's freed with a zap pattern so you'd find bugs that way?
Yes, you are right, maybe that's sufficient. I thought that the zap pattern would be overwritten with the first allocation wave (allocate a bunch, reset-to-mark, allocate again) but I see reset-to-mark - ultimately Chunk::chop() - also zaps, so this may be fine.
> Anyway, it might be better as a separate RFE and new round of testing.
Yes. But the default pattern may be fine already.
> Thanks for default aligning the chunks though because this is what one would expect without looking at the code more closely.
Sure!
-------------
PR: https://git.openjdk.java.net/jdk/pull/4835
More information about the hotspot-dev
mailing list