RFR: 8270061: Change parameter order of ResourceHashtable

Ioi Lam iklam at openjdk.java.net
Tue Jul 27 16:24:41 UTC 2021


The template parameter for ResourceHashtable is currently in this order:

template<
    typename K, typename V,
    unsigned (*HASH)  (K const&)           = primitive_hash<K>,
    bool     (*EQUALS)(K const&, K const&) = primitive_equals<K>,
    unsigned SIZE = 256,
    ResourceObj::allocation_type ALLOC_TYPE = ResourceObj::RESOURCE_AREA,
    MEMFLAGS MEM_TYPE = mtInternal
    >
class ResourceHashtable {...}


However, more often than not, default values of `HASH` and `EQUALS` will be used, where the other parameters may need to be specified.

We should move the `HASH` and `EQUALS` parameters to the end of the parameter list.

-------------

Commit messages:
 - 8270061: Change parameter order of ResourceHashtable

Changes: https://git.openjdk.java.net/jdk/pull/4912/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4912&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8270061
  Stats: 97 lines in 18 files changed: 24 ins; 48 del; 25 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4912.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4912/head:pull/4912

PR: https://git.openjdk.java.net/jdk/pull/4912


More information about the hotspot-dev mailing list