RFR: 8017163: G1: Refactor remembered sets [v4]

[Stefan Johansson]

On Tue, 1 Jun 2021 09:44:14 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> src/hotspot/share/gc/g1/heapRegionRemSet.hpp line 126:
>> 
>>> 124:       // This correction is necessary because the above includes the second
>>> 125:       // part.
>>> 126:       + (sizeof(HeapRegionRemSet) - sizeof(G1CardSet))
>> 
>> Pre-existing, but what do you think about moving/including the comment for this part of the calculation in the function comment.
>
> I think the comment should stay where it is - it is confusing otherwise, and establishing the context for this seems hard. I can remove the comment if you want though.

Removing sounds good to me :) Or fit it on one line like this:

      + (sizeof(HeapRegionRemSet) - sizeof(G1CardSet)) // Avoid double counting G1CardSet

-------------

PR: https://git.openjdk.java.net/jdk/pull/4116