RFR: 8267920: Create separate Events buffer for VMOperations [v2]

David Holmes david.holmes at oracle.com
Wed Jun 2 10:42:35 UTC 2021


On 2/06/2021 4:38 pm, Stefan Karlsson wrote:
> On Mon, 31 May 2021 08:56:48 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
> 
>>> Hi Stefan,
>>> Adding the new event buffer itself seems fine.
>>> Unlike Coleen I can't figure out why you added LogFunction and the new template classes. :) I can't tell if this was necessary or you just preferred to re-do the specialization mechanism. ??
>>> Thanks,
>>> David
>>
>> It was mostly done to not duplicate the code of EventMark when adding new EventMarkX classes. This can probably be done different ways. I'm open to suggestions.
> 
> @dholmes-ora Have you had time to think about this?

No, sorry. Fine to proceed.

Thanks,
David

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/4243
> 


More information about the hotspot-dev mailing list