RFR: 8266749: AArch64: Backtracing broken on PAC enabled systems [v6]

[Alan Hayward]

On Wed, 2 Jun 2021 10:02:45 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Alan Hayward has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove asserts / fix build
>>   
>>   CustomizedGitHooks: yes
>>   Change-Id: I6b634b90e81cf8f6e4cd1cdc63f6926eaa7025f6
>
> src/hotspot/cpu/aarch64/pauth_aarch64.hpp line 31:
> 
>> 29: 
>> 30: inline bool pauth_ptr_is_raw(address ptr) {
>> 31:   // Confirm none of the high bits are set in the pointer.
> 
> This predicate seems to me to be be misnamed: it's checking for unsigned/stripped, not for raw. The raw value is whatever gets saved in LR/pushed onto the stack.

Ah, yes, because the name pauth_ptr_is_raw() now clashes with sender_pc_raw().

I'll fix up, one way or the other. Don't really want to call it pauth_ptr_is_unsigned() or pauth_ptr_is_authenticated(), because they seem to imply different things at first glance.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4029