RFR: 8268119: Rename copy_os_cpu.inline.hpp files to copy_os_cpu.hpp

Kim Barrett kbarrett at openjdk.java.net
Wed Jun 2 14:43:30 UTC 2021


On Wed, 2 Jun 2021 14:28:57 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> Today we transitively include the `copy_<os>_<cpu>.inline.hpp` files from `copy.hpp`. This is goes against the HotSpot Style Guide that states:
> 
>> .inline.hpp files should only be included in .cpp or .inline.hpp files.
> 
> The `copy_<os>_<cpu>.inline.hpp` don't include any other HotSpot files, so I propose that we simply rename them to `copy_<os>_<cpu>.hpp`.

Looks good.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4311


More information about the hotspot-dev mailing list