RFR: 8266257: Fix foreign linker build issues for ppc and s390

Martin Doerr mdoerr at openjdk.java.net
Wed Jun 2 17:28:34 UTC 2021


On Wed, 2 Jun 2021 11:27:28 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> This patch addresses some build issues introduced by integration of JEP-412.
> The support for JEP-412 turns some static functions (e.g.`float_move`, `long_move`) in sharedRuntime into proper member functions, as they need to be referenced by the new support for Panama upcall handlers. Sadly, not all Hotspot ports agree on the number of parameters these functions take - most notably, ppc and s390 have incompatible signatures, and, because of that, failt to build.
> 
> A simpler solution is to move these functions to the x86 macro assembler - after all, these functions are specific to a given platform, and excessive sharing should be avoided. This patch does that - and fixes other remaining issues with non-standard hotspot builds (e.g. by adding stab implementation for some unimplemented Panama support).

I just verified that it builds on real machines. Thanks for fixing!

-------------

PR: https://git.openjdk.java.net/jdk/pull/4303


More information about the hotspot-dev mailing list