RFR: 8268118: Rename bytes_os_cpu.inline.hpp files to bytes_os_cpu.hpp
Coleen Phillimore
coleenp at openjdk.java.net
Wed Jun 2 17:29:33 UTC 2021
On Wed, 2 Jun 2021 14:27:43 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
> Today we transitively include the `bytes_<os>_<cpu>.inline.hpp` files from `bytes.hpp`. This is goes against the HotSpot Style Guide that states:
>
>> .inline.hpp files should only be included in .cpp or .inline.hpp files.
>
> The `bytes_<os>_<cpu>.inline.hpp` don't include any other HotSpot files, so I propose that we simply rename them to `bytes_<os>_<cpu>.hpp`.
Seems fine and trivial if you've compiled it on all these platforms (we have cross compilations for ppc and s390).
I guess we picked .inline.hpp for the file names since the define inline functions but it's better to avoid breaking the .inline.hpp rule.
-------------
Marked as reviewed by coleenp (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4310
More information about the hotspot-dev
mailing list