RFR: 8268118: Rename bytes_os_cpu.inline.hpp files to bytes_os_cpu.hpp

David Holmes dholmes at openjdk.java.net
Thu Jun 3 03:03:38 UTC 2021


On Wed, 2 Jun 2021 14:27:43 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> Today we transitively include the `bytes_<os>_<cpu>.inline.hpp` files from `bytes.hpp`. This is goes against the HotSpot Style Guide that states:
> 
>> .inline.hpp files should only be included in .cpp or .inline.hpp files.
> 
> The `bytes_<os>_<cpu>.inline.hpp` don't include any other HotSpot files, so I propose that we simply rename them to `bytes_<os>_<cpu>.hpp`.

Seems okay. As the inline definitions are trivial they don't need to be in an inline.hpp file.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4310


More information about the hotspot-dev mailing list