RFR: 8268164: Adopt cast notation for WorkerThread conversions [v2]

David Holmes dholmes at openjdk.java.net
Thu Jun 3 13:05:38 UTC 2021


On Thu, 3 Jun 2021 12:51:01 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/runtime/nonJavaThread.hpp line 111:
> 
>> 109: 
>> 110:   static WorkerThread* cast(Thread* t) {
>> 111:     assert(t->is_Worker_thread(), "incorrect cast to const WorkerThread");
> 
> It should probably not say *const* here.

`as_Worker_thread()` used const so I wonder whether the new cast function should too?

-------------

PR: https://git.openjdk.java.net/jdk/pull/4334


More information about the hotspot-dev mailing list