RFR: 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash [v2]

[David Holmes]

Hi Dan,

On 4/06/2021 7:24 am, Daniel D.Daugherty wrote:
> On Thu, 3 Jun 2021 17:24:07 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
> 
>>> Fixed a race condition between posting and enabling DynamicCodeGenerated event.
>>
>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>>
>>    fixed comment
> 
> test/hotspot/jtreg/serviceability/jvmti/DynamicCodeGenerated/DynamicCodeGeneratedTest.java line 55:
> 
>> 53:                 Reference.reachabilityFence(result);
>> 54:             }).start();
>> 55:         }
> 
> I just noticed no `join()` calls to clean up these threads.

Java doesn't need a join() to "cleanup threads". The main reason to 
join() threads in a test is to ensure they have terminated before we 
hand control back to jtreg; and if not daemons to ensure we terminate 
more predictably.

Cheers,
David
-----

> Does this mean we'll have 10,000 thread objects waiting around
> until the end of the program?
> 
> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/4331
>