RFR: 8268178: Extract sender frame parsing to CodeBlob::FrameParser [v2]

Ludovic Henry luhenry at openjdk.java.net
Fri Jun 4 08:55:26 UTC 2021


> Whether and how a frame is setup is controlled by the code generator
> for the specific CodeBlock. The CodeBlock is then in the best place to know how
> to parse the sender's frame from the current frame in the given CodeBlock.
> 
> This refactoring proposes to extract this parsing out of `frame` and into a
> `CodeBlock::FrameParser`. This FrameParser is then specialized in the relevant
> inherited children of CodeBlock.
> 
> This change is to largely facilitate adding new supported cases for JDK-8252417 [1]
> like runtime stubs.
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8252417

Ludovic Henry has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Fix type casting for Windows
 - Merge branch 'master' of https://github.com/openjdk/jdk into codeblob-frameparser
 - 8268178: Extract sender frame parsing to CodeBlock::FrameParser
   
   Whether and how a frame is setup is controlled by the code generator
   for the specific CodeBlock. The CodeBlock is then in the best place to know how
   to parse the sender's frame from the current frame in the given CodeBlock.
   
   This refactoring proposes to extract this parsing out of `frame` and into a
   `CodeBlock::FrameParser`. This FrameParser is then specialized in the relevant
   inherited children of CodeBlock.
   
   This change is to largely facilitate adding new supported cases for JDK-8252417
   like runtime stubs.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4337/files
  - new: https://git.openjdk.java.net/jdk/pull/4337/files/63e89d87..714ec5fb

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4337&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4337&range=00-01

  Stats: 426534 lines in 279 files changed: 425213 ins; 394 del; 927 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4337.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4337/head:pull/4337

PR: https://git.openjdk.java.net/jdk/pull/4337


More information about the hotspot-dev mailing list