RFR: 8268178: Extract sender frame parsing to CodeBlob::FrameParser [v3]

Ludovic Henry luhenry at openjdk.java.net
Fri Jun 4 10:48:59 UTC 2021


On Fri, 4 Jun 2021 10:21:26 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

>> Ludovic Henry has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix Windows build
>>  - Fix zero build
>
> src/hotspot/share/code/icBuffer.cpp line 146:
> 
>> 144:   BufferBlob* blob = BufferBlob::create("InlineCacheBuffer", code_size);
>> 145:   if (blob == NULL) {
>> 146:     vm_exit_out_of_memory(code_size, OOM_MALLOC_ERROR, "CodeCache: no room for InlineCacheBuffer");
> 
> Is VM exit here appropriate?
> AFAICS, previously the failure to allocate InlineCacheBuffer was caught in assertion only.

This is extracted from https://github.com/openjdk/jdk/pull/4337/files#diff-044ffb3850314d23822b79de889820f6432757df5431eac3748a9eb60b1b6899L69-L73.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4337


More information about the hotspot-dev mailing list