RFR: 8267968: [PPC64] Use prefixed load and addi instructions for better performance in POWER10 [v2]

Kazunori Ogata ogatak at openjdk.java.net
Sun Jun 6 20:28:28 UTC 2021


On Fri, 4 Jun 2021 07:04:58 GMT, Michihiro Horie <mhorie at openjdk.org> wrote:

>> Kazunori Ogata has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve comments in macroAssembler_ppc.cpp
>
> src/hotspot/cpu/ppc/macroAssembler_ppc.cpp line 311:
> 
>> 309:     return inv_d1_field(inst1);
>> 310:   } else if (PowerArchitecturePPC64 >= 10 && is_pld_prefix(inst1)) {
>> 311:     return (get_imm18(inst1_addr, 0) << 16) + (get_imm(inst1_addr, 1) & 0xffff);
> 
> I couldn't understand here quickly. Maybe it would be nice to tell the reason by adding some comments like is_load_const_from_method_toc_at's one "CallDynamicJavaDirectSched_ExNode and CallLeaf(NoFP)Direct_ExNode are the nodes that require relocation and use pld".

Thank you for your suggestion.  I added the comment (and made some wordsmith in both is_load_const_from_method_toc_at and get_offset_of_load_const_from_method_toc_at).

-------------

PR: https://git.openjdk.java.net/jdk/pull/4267


More information about the hotspot-dev mailing list