RFR: 8268178: Extract sender frame parsing to CodeBlob::FrameParser [v5]

Ludovic Henry luhenry at openjdk.java.net
Mon Jun 7 12:56:53 UTC 2021


> Whether and how a frame is setup is controlled by the code generator
> for the specific CodeBlock. The CodeBlock is then in the best place to know how
> to parse the sender's frame from the current frame in the given CodeBlock.
> 
> This refactoring proposes to extract this parsing out of `frame` and into a
> `CodeBlock::FrameParser`. This FrameParser is then specialized in the relevant
> inherited children of CodeBlock.
> 
> This change is to largely facilitate adding new supported cases for JDK-8252417 [1]
> like runtime stubs.
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8252417

Ludovic Henry has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  8268178: Extract sender frame parsing to CodeBlock::FrameParser
  
  Whether and how a frame is setup is controlled by the code generator
  for the specific CodeBlock. The CodeBlock is then in the best place to know how
  to parse the sender's frame from the current frame in the given CodeBlock.
  
  This refactoring proposes to extract this parsing out of `frame` and into a
  `CodeBlock::FrameParser`. This FrameParser is then specialized in the relevant
  inherited children of CodeBlock.
  
  This change is to largely facilitate adding new supported cases for JDK-8252417
  like runtime stubs.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4337/files
  - new: https://git.openjdk.java.net/jdk/pull/4337/files/2800cc50..3b445203

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4337&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4337&range=03-04

  Stats: 4 lines in 4 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4337.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4337/head:pull/4337

PR: https://git.openjdk.java.net/jdk/pull/4337


More information about the hotspot-dev mailing list