RFR: 8265954: Shared classes that failed to load should not be loaded again
Yumin Qi
minqi at openjdk.java.net
Wed Jun 9 16:31:24 UTC 2021
Hi, Please review
Shared classes should not be loaded again at failed loading from CDS. In the failed case, restore_unshareable_info failed due to some reason (OOM), but the class already polluted and failed to be loaded again.
Using the unused bit in _misc_flags indicates shared loading status to prevent it from being loaded again.
Tests: tier1,tier2,tier3,tier4,tier7
Local tests: jtreg/hotspot/runtime/cds
TestDynamicDumpAtOom.java (which failed in tier7) with variant allocation sizes (used to reproduce the failure) passed.
Thanks
Yumin
-------------
Commit messages:
- 8265954: Shared classes that failed to load should not be loaded again
Changes: https://git.openjdk.java.net/jdk/pull/4434/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4434&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8265954
Stats: 72 lines in 6 files changed: 36 ins; 21 del; 15 mod
Patch: https://git.openjdk.java.net/jdk/pull/4434.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/4434/head:pull/4434
PR: https://git.openjdk.java.net/jdk/pull/4434
More information about the hotspot-dev
mailing list