RFR: 8268125: ZGC: Clone oop array gets wrong acopy stub [v6]

[Vladimir Ivanov]

On Mon, 14 Jun 2021 19:53:16 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:

>> Hi,
>> 
>> This fixes a problem I introduced with JDK-8267726. With that change clone oop array is treated as normal clone arrays with ZGC. I missed that a case was missing in zBarrierSetC2::clone_at_expansion - which caused clone_oop-arrays to get the wrong array copy stub.
>> 
>> In this fix I move the entire leaf call creation inside zBarrierSetC2, and leave BarrierSetC2 as is. In this way I don't have to change anything for the other collectors.
>> 
>> Please review,
>> Best regards,
>> Nils Eliasson
>
> Nils Eliasson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   added newline at eof

Marked as reviewed by vlivanov (Reviewer).

test/hotspot/jtreg/compiler/arraycopy/TestObjectArrayClone.java line 29:

> 27:  * @summary Test Object.clone() intrinsic if ReduceInitialCardMarks is disabled.
> 28:  *
> 29:  * @run main/othervm -XX:+IgnoreUnrecognizedVMOptions -XX:-ReduceInitialCardMarks

Considering the complications `-XX:+StressReflectiveCode` introduces, does it make sense to add a configuration with the flag explicitly enabled?

-------------

PR: https://git.openjdk.java.net/jdk/pull/4359