[jdk17] RFR: 8268739: AArch64: Build failure after JDK-8267663

[David Holmes]

On Wed, 16 Jun 2021 08:47:46 GMT, Eric Liu <eliu at openjdk.org> wrote:

> The failure is cased by the build option "--with-jvm-variants=client".
> In client mode, BoolTest[1] is used by "neon_compare"[2] but not
> declared in macroAssembler_aarch64.hpp[3].
> 
> Since "neon_compare" is c2 specific, this patch moves it to
> c2_MacroAssembler_aarch64.cpp.
> 
> [1] https://github.com/openjdk/jdk17/blob/master/src/hotspot/share/opto/subnode.hpp#L308
> [2] https://github.com/openjdk/jdk17/blob/master/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp#L5342
> [3] https://github.com/openjdk/jdk17/blob/master/src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp#L58

Seems fine. I assume the processing of the ad file will already check both MacroAssembler and C2_MacroAssembler for the definition?

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk17/pull/73