RFR: 8017163: G1: Refactor remembered sets [v13]

Thomas Schatzl tschatzl at openjdk.java.net
Fri Jun 18 08:56:34 UTC 2021


On Thu, 17 Jun 2021 15:34:21 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   sjohanss review - remove debug code
>
> src/hotspot/share/gc/g1/g1CardSet.cpp line 146:
> 
>> 144:   }
>> 145: }
>> 146: 
> 
> Unused from what I can tell.
> Suggestion:

Yes, after the change to add `subtract_from`...

> src/hotspot/share/gc/g1/g1CardSet.cpp line 839:
> 
>> 837:   return occupied() <= limit;
>> 838: }
>> 839: 
> 
> Unused.
> Suggestion:

I forgot to forward to this method in `HeapRegionRemSet::occupancy_less_or_equal_than()`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4116


More information about the hotspot-dev mailing list