RFR: 8268229: Aarch64: Use Neon in intrinsics for String.equals [v2]

Wang Huang whuang at openjdk.java.net
Thu Jun 24 09:26:32 UTC 2021


On Tue, 15 Jun 2021 03:20:06 GMT, Nick Gasson <ngasson at openjdk.org> wrote:

>> Wang Huang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   enhancement of string.equals
>
> src/hotspot/cpu/aarch64/aarch64.ad line 16676:
> 
>> 16674:   format %{ "String Equals $str1,$str2,$cnt -> $result" %}
>> 16675:   ins_encode %{
>> 16676:     // Count is in 8-bit bytes; non-Compact chars are 8 bits.
> 
> This change is a bit confusing: non-compact chars are still 16 bits, it's just at this point we know the string contains only 8-bit Latin characters. I think it's better to instead delete everything after the ";" (or leave it as it is).

I have fixed this comment. Thank you for your suggestion.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4423


More information about the hotspot-dev mailing list