RFR: 8269417: Minor clarification on NonblockingQueue utility [v3]

Ivan Walulya iwalulya at openjdk.java.net
Tue Jun 29 09:25:11 UTC 2021


On Mon, 28 Jun 2021 22:38:43 GMT, Man Cao <manc at openjdk.org> wrote:

>> Hi,
>> 
>> Could you review this change mainly based on the comments in https://github.com/openjdk/jdk/pull/4379?
>> I also added an assertion to ensure and better understand why the Atomic::store() in append() is correct.
>> 
>> Stress tested with fastdebug build with:
>> $ make test TEST="gtest:NonblockingQueueTestBasics gtest:NonblockingQueueTest" GTEST="REPEAT=-1"
>
> Man Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into 8269417
>  - Clarify cmpxchg only fail due to try_pop.
>  - Clarify NonblockingQueue's comments and add an assertion.

lgtm!

-------------

Marked as reviewed by iwalulya (Committer).

PR: https://git.openjdk.java.net/jdk/pull/4600


More information about the hotspot-dev mailing list