RFR: 8262491: AArch64: CPU description should contain compatible board list [v2]

Yasumasa Suenaga ysuenaga at openjdk.java.net
Mon Mar 1 14:50:00 UTC 2021


On Mon, 1 Mar 2021 13:57:45 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refactoring
>
> src/hotspot/os_cpu/linux_aarch64/vm_version_linux_aarch64.cpp line 172:
> 
>> 170: 
>> 171: void VM_Version::get_compatible_board(char *buf, int buflen) {
>> 172:   const char *aarch64_label = "AArch64";
> 
> All platforms seem to declare themselves `AArch64`, this probably can be in the shared aarch64 code.

VM_Version is not inherited, and platform-specific functions are declared in os_linux and os_windows. So I think it is difficult to declare shared (default) function for this purpose.
It is the best if we declare shared function, and override it like a virtual function. But it seems to be difficult. Do you have any idea?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2759


More information about the hotspot-dev mailing list