RFR: 8213269: convert test/hotspot/jtreg/runtime/memory/RunUnitTestsConcurrently to gtest [v2]
Mikhailo Seledtsov
mseledtsov at openjdk.java.net
Mon Mar 1 18:42:20 UTC 2021
> This is a preliminary review. I would like to get the initial feedback before I proceed with conversion of the remaining tests.
>
> Here is what I did so far:
> - created a UnitTestThread and a main test runner, based on gtests with similar needs
> - moved the original code from HotSpot internals (so called hotspot internal tests: src/hotspot/share/memory/virtualspace.cpp)
> to the newly created gtest while wrapping it into a TestReservedSpace class. I did not change the code of the test.
> - removed invocations from whitebox.cpp
>
> Testing:
> - ran GTestWrapper on usual platforms - All PASS
> - ensured that ReservedSpaceConcurrent is in the logs and passed
>
> After gathering the feedback my plan is:
> Plan:
> - move the remaining internal Memory/VirtualSpace tests into a gTest
> - I am thinking about using separate files for each test
> - create a common file for UnitTestThread and MultiThreadTestRunner to reuse the code
Mikhailo Seledtsov has updated the pull request incrementally with three additional commits since the last revision:
- Adding const qualifiers
- Renaming concurrentTestRunner.inline.hpp to follow hotspot_naming_convention for c/cpp/hpp files
- Making TestRunnable to be pure virtual
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2436/files
- new: https://git.openjdk.java.net/jdk/pull/2436/files/4076519f..8c626c88
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2436&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2436&range=00-01
Stats: 203 lines in 5 files changed: 96 ins; 100 del; 7 mod
Patch: https://git.openjdk.java.net/jdk/pull/2436.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/2436/head:pull/2436
PR: https://git.openjdk.java.net/jdk/pull/2436
More information about the hotspot-dev
mailing list