RFR: 8213269: convert test/hotspot/jtreg/runtime/memory/RunUnitTestsConcurrently to gtest [v3]

Mikhailo Seledtsov mseledtsov at openjdk.java.net
Tue Mar 2 00:00:18 UTC 2021


On Mon, 1 Mar 2021 21:30:58 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

>> Mikhailo Seledtsov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed memory leak
>
> test/hotspot/gtest/memory/test_virtualspace.cpp line 681:
> 
>> 679:   ConcurrentTestRunner testRunner(runnable, 30, 15000);
>> 680:   testRunner.run();
>> 681:   delete runnable;
> 
> wouldn't it be easier to allocate TestRunnable on stack and pass a pointer?
> Suggestion:
> 
>   VirtualSpaceRunnable runnable();
>   ConcurrentTestRunner testRunner(&runnable, 30, 15000);
>   testRunner.run();

Thanks Igor for these suggestions. I have updated the code accordingly.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2436


More information about the hotspot-dev mailing list